Support Basic Authentication for archive downloads #35087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
|
It just occurred to be that the PR/commit title should say "repository archive" rather than just "archive". Not changing it now since https://github.com/go-gitea/gitea/blob/main/CONTRIBUTING.md#maintaining-open-prs possibly implies that I shouldn't. (Unless someone says it's OK to do.) |
|
It's better to have a test for that. |
Where could a test be added, what would it test, and how would I run such a test? (I don't know a thing about testing facilities of Gitea - or of Go in general, for that matter.) When I look at #33371 for inspiration, I only find something that looks like a test for the |
wxiaoguang
approved these changes
Jul 16, 2025
GiteaBot
added
lgtm/need 1
hiifong
approved these changes
Jul 16, 2025
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jul 18, 2025
* giteaofficial/main: [skip ci] Updated translations via Crowdin Increase gap on latest commit (go-gitea#35104) Fix job status aggregation logic (go-gitea#35000) Fix some missed GitHeadRefName when renaming (go-gitea#35102) Fix error logs and improve some comments/messages (go-gitea#35105) Support Basic Authentication for archive downloads (go-gitea#35087) Run `uv run` with `--frozen` (go-gitea#35097) Improve package API log handling (go-gitea#35100) Rename pull request GetGitRefName to GetGitHeadRefName (go-gitea#35093) Fix review comment/dimiss comment x reference can be refereced back (go-gitea#35094) Fix submodule nil check (go-gitea#35096) Redirect to a presigned URL of HEAD for HEAD requests (go-gitea#35088)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #35083